You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/13 02:42:16 UTC

[GitHub] [airflow] jhtimmins commented on a change in pull request #15195: Fix dag sort in dag stats

jhtimmins commented on a change in pull request #15195:
URL: https://github.com/apache/airflow/pull/15195#discussion_r612088046



##########
File path: airflow/utils/dag_processing.py
##########
@@ -834,7 +834,7 @@ def _log_file_processing_stats(self, known_file_paths):
             rows.append((file_path, processor_pid, runtime, num_dags, num_errors, last_runtime, last_run))
 
         # Sort by longest last runtime. (Can't sort None values in python3)

Review comment:
       This seems to suggest that it's sorting the results by the length of each DAG's last runtime. Is your change sorting by the time of the last runtime? Or was it not sorting in the way the comment suggests and you're just fixing it?
   
   If it's the former, can you update the comment to reflect the new sort order?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org