You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/22 22:26:34 UTC

[GitHub] [incubator-mxnet] vladoovtcharov opened a new pull request #19409: [FEATURE] Add option to build with shared c runtime on windows

vladoovtcharov opened a new pull request #19409:
URL: https://github.com/apache/incubator-mxnet/pull/19409


   ## Description ##
   Often it is desirable to use a shared c runtime when build a shared lib on windows. Third party dependencies DMLC and GTEST support this so adding support to mxnet is now easier
   
   ### Changes ###
   Changed cmake file to not replace 'MD' flags with 'MT' flags if MXNET_FORCE_SHARED_CRT is enabled.
   MXNET_FORCE_SHARED_CRT is enabled by default if building a shared lib
   Fixed linking for some Debug (which linked to MD instead of MDd) 
   Added missing RelWithDebinfo and MinSizeRel configurations which were missing in parts.
   
   ## Comments ##
   Not sure if this should be the default when building a shared lib on windows or just an option?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19409: [FEATURE] Add option to build with shared c runtime on windows

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19409:
URL: https://github.com/apache/incubator-mxnet/pull/19409#issuecomment-715458205


   Jenkins CI successfully triggered : [centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19409: [FEATURE] Add option to build with shared c runtime on windows

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19409:
URL: https://github.com/apache/incubator-mxnet/pull/19409#issuecomment-714796659


   Hey @vladoovtcharov , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-gpu, website, sanity, centos-gpu, windows-cpu, centos-cpu, clang, windows-gpu, miscellaneous, unix-cpu, edge]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] vladoovtcharov commented on pull request #19409: [FEATURE] Add option to build with shared c runtime on windows

Posted by GitBox <gi...@apache.org>.
vladoovtcharov commented on pull request #19409:
URL: https://github.com/apache/incubator-mxnet/pull/19409#issuecomment-715458155


   @mxnet-bot run ci [greeting, centos-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #19409: [FEATURE] Add option to build with shared c runtime on windows

Posted by GitBox <gi...@apache.org>.
szha merged pull request #19409:
URL: https://github.com/apache/incubator-mxnet/pull/19409


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org