You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/02 21:37:31 UTC

[GitHub] [arrow-datafusion] alamb opened a new issue, #6195: Port remaining sql integration tests from `rust `to `sqllogictest`

alamb opened a new issue, #6195:
URL: https://github.com/apache/arrow-datafusion/issues/6195

   ### Is your feature request related to a problem or challenge?
   
   
   As described in https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests DataFusion has many tests that use the sqllogictest framework which is easy to write and update compared to rust tests
   
   We still have a non trivial number of old tests that are written in Rust and run in the sql integration test:
   https://arrow.apache.org/datafusion/contributor-guide/index.html#rust-integration-tests
   
   ```
   cargo test -p datafusion --test sql_integration
   ```
   
   This ticket tracks the work to port the tests from rust to sqllogictests
   
   
   
   ### Describe the solution you'd like
   
   Port tests from [datafusion/core/tests/sql](https://github.com/apache/arrow-datafusion/tree/master/datafusion/core/tests/sql) to sqllogictests in [datafusion/core/tests/sqllogictests/test_files](https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests/test_files)
   
   For each test, the goal is to:
   1. Port as many tests as possiible (follow the example of https://github.com/apache/arrow-datafusion/pull/6158 or one of the other tests linked to https://github.com/apache/arrow-datafusion/issues/4495)
   
   Then we can figure out what to do with the tests that can not be ported easily
   # Remaining items:
   (TODO make a list)
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   Follow on to https://github.com/apache/arrow-datafusion/issues/4495
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jiangzhx commented on issue #6195: Port remaining sql integration tests from `rust `to `sqllogictest`

Posted by "jiangzhx (via GitHub)" <gi...@apache.org>.
jiangzhx commented on issue #6195:
URL: https://github.com/apache/arrow-datafusion/issues/6195#issuecomment-1586686480

   i'm start working on [Port tests in joins.rs to sqllogictest #6302](https://github.com/apache/arrow-datafusion/issues/6302)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Port remaining sql integration tests from `rust `to `sqllogictest` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6195:
URL: https://github.com/apache/arrow-datafusion/issues/6195#issuecomment-1913621208

   Thank you to everyone who helped get this done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Port remaining sql integration tests from `rust `to `sqllogictest` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #6195: Port remaining sql integration tests from `rust `to `sqllogictest`
URL: https://github.com/apache/arrow-datafusion/issues/6195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org