[GitHub] Shimi edited a comment on issue #3562: Concise File mapping handling with FileUtils.map()

[GitBox <gi...@apache.org>]

Shimi edited a comment on issue #3562: Concise File mapping handling with FileUtils.map()
URL: https://github.com/apache/incubator-druid/issues/3562#issuecomment-439171030
 
 
   thanks @ leventov 
   I made the changes to VSizeSerdeBenchmark. Except for the benchmarks, all places require write access and FileUtils.map() map the files as read-only.
   If I understand it right the main motivation for this ticket (according to https://github.com/metamx/java-util/pull/50#issue-83823490) is to control the release of the memory and not leave it for the GC. I wonder if it's important for the benchmarks since the GC will release the memory when the benchmark ends.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org