You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by nakomis <gi...@git.apache.org> on 2014/11/20 10:57:47 UTC
[GitHub] incubator-brooklyn pull request: Adds entitlement check to state c...
GitHub user nakomis opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/351
Adds entitlement check to state checks
Resolves BROOKLYN-82
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/incubator-brooklyn BROOKLYN-82-health-check-call
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/351.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #351
----
commit 2bcdf649b84ea0d3f46134cbf06b93b74d5e14e4
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-11-20T09:55:51Z
Adds entitlement check to state checks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds entitlement check to state c...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/351#issuecomment-63816183
Looks good. Can you add a test as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds entitlement check to state c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Adds entitlement check to state c...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/351#issuecomment-72011736
looks fine to me. a test would be nice but it's so small i don't think we should hold it up. merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---