You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/26 06:50:43 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2111: LIBCXX related fixes

xiaoxiang781216 commented on a change in pull request #2111:
URL: https://github.com/apache/incubator-nuttx/pull/2111#discussion_r511746839



##########
File path: libs/libxx/libcxx-misc.patch
##########
@@ -0,0 +1,22 @@
+--- libcxx/src/locale.cpp.orig4	2020-10-23 07:25:28.000000000 +0900
++++ libcxx/src/locale.cpp	2020-10-23 07:25:38.000000000 +0900

Review comment:
       let's merge the patch into one?

##########
File path: libs/libxx/libcxx.defs
##########
@@ -20,22 +20,61 @@
 
 VERSION=11.0.0
 
-$(TOPDIR)/include/libcxx:
+libcxx-$(VERSION).src.tar.xz:

Review comment:
       why need keep the tarball?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org