[GitHub] [lucene-solr] murblanc commented on pull request #2179: SOLR-15055 Re-implement 'withCollection' and 'maxShardsPerNode'

[GitBox <gi...@apache.org>]

murblanc commented on pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#issuecomment-754989462


   **Blocking issue**: `CreateCollectionCmd` is not the only place where `withCollection` logic is going to get applied. All calls that end up calling the placement plugins now need to deal with returned placement for multiple collections: `SplitShardCmd`, `AddReplicaCmd`, `ReplaceNodeCmd`, `RestoreCmd`. Or at least ignore the additional replica assignments being returned.
   
   I also see `CollectionsRepairEventListener`. We will also eventually have cluster rebalancers, will we expect them to support `withCollection`?
   
   Dealing with replica placement for multiple collections returned from the placement plugins seems to deserve to be made a "first class" abstraction if we want to implement this (unreasonable?) feature in a reasonable way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org