You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/10/09 23:54:15 UTC
[kudu-CR] pb util: avoid repeated stat() calls reading files
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8010
to look at the new patch set (#3).
Change subject: pb_util: avoid repeated stat() calls reading files
......................................................................
pb_util: avoid repeated stat() calls reading files
This reduces the number of fstat syscalls while loading a host with 11M blocks
from 29.3M to 147K.
Note that this also changes Env to return EndOfFile when reading from
disk rather than IOError as it used to.
Change-Id: I27371800604bcb20bafae7946d3b3e84af094598
---
M src/kudu/util/env_posix.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/pb_util.h
4 files changed, 58 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/8010/3
--
To view, visit http://gerrit.cloudera.org:8080/8010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I27371800604bcb20bafae7946d3b3e84af094598
Gerrit-Change-Number: 8010
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins