You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2009/01/22 22:52:41 UTC
Re: svn commit: r736809 - /httpd/httpd/trunk/modules/cluster/mod_heartbeat.c
On 01/22/2009 10:47 PM, pquerna@apache.org wrote:
> Author: pquerna
> Date: Thu Jan 22 13:47:16 2009
> New Revision: 736809
>
> URL: http://svn.apache.org/viewvc?rev=736809&view=rev
> Log:
> Use the more traditional create/clear/destroy style for the main loop pool.
> Suggested by: jerenkrantz
>
> Modified:
> httpd/httpd/trunk/modules/cluster/mod_heartbeat.c
>
> Modified: httpd/httpd/trunk/modules/cluster/mod_heartbeat.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cluster/mod_heartbeat.c?rev=736809&r1=736808&r2=736809&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/cluster/mod_heartbeat.c (original)
> +++ httpd/httpd/trunk/modules/cluster/mod_heartbeat.c Thu Jan 22 13:47:16 2009
> @@ -137,9 +138,10 @@
> apr_sleep(apr_time_from_msec(200));
> }
>
> + apr_pool_create(&tpool, pool);
> while (ctx->keep_running) {
> + apr_pool_clear(tpool);
> int mpm_state = 0;
> - apr_pool_t *tpool;
>
> rv = ap_mpm_query(AP_MPMQ_MPM_STATE, &mpm_state);
>
> @@ -152,13 +154,12 @@
> break;
> }
>
> - apr_pool_create(&tpool, pool);
> apr_pool_tag(tpool, "heartbeat_worker_temp");
Nitpick: This could be moved outside the loop as well.
Regards
Rüdiger
Re: svn commit: r736809 - /httpd/httpd/trunk/modules/cluster/mod_heartbeat.c
Posted by Paul Querna <ch...@force-elite.com>.
Ruediger Pluem wrote:
>
> On 01/22/2009 10:47 PM, pquerna@apache.org wrote:
>> Author: pquerna
>> Date: Thu Jan 22 13:47:16 2009
>> New Revision: 736809
>>
>> URL: http://svn.apache.org/viewvc?rev=736809&view=rev
>> Log:
>> Use the more traditional create/clear/destroy style for the main loop pool.
>> Suggested by: jerenkrantz
>>
>> Modified:
>> httpd/httpd/trunk/modules/cluster/mod_heartbeat.c
>>
>> Modified: httpd/httpd/trunk/modules/cluster/mod_heartbeat.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cluster/mod_heartbeat.c?rev=736809&r1=736808&r2=736809&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/cluster/mod_heartbeat.c (original)
>> +++ httpd/httpd/trunk/modules/cluster/mod_heartbeat.c Thu Jan 22 13:47:16 2009
>
>> @@ -137,9 +138,10 @@
>> apr_sleep(apr_time_from_msec(200));
>> }
>>
>> + apr_pool_create(&tpool, pool);
>> while (ctx->keep_running) {
>> + apr_pool_clear(tpool);
>> int mpm_state = 0;
>> - apr_pool_t *tpool;
>>
>> rv = ap_mpm_query(AP_MPMQ_MPM_STATE, &mpm_state);
>>
>> @@ -152,13 +154,12 @@
>> break;
>> }
>>
>> - apr_pool_create(&tpool, pool);
>> apr_pool_tag(tpool, "heartbeat_worker_temp");
>
> Nitpick: This could be moved outside the loop as well.
>
fixed in r736822,
Thanks,
Paul