You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/22 00:00:03 UTC

[GitHub] [airflow] syudb opened a new pull request #10462: Updated REST API call so GET requests pass payload in query string instead of request body

syudb opened a new pull request #10462:
URL: https://github.com/apache/airflow/pull/10462


   This PR addresses an issue with the way GET requests were being built/sent. In the original implementation, the request payload is sent in the body of the request and not in the query string parameters, which can be lost when the traffic passes through a WAF.
   
   This in turn causes the operator to fail while polling for job status (GET) after a successful submission (POST).
   
   I made a similar PR in the v1.10-stable branch, this one addresses the hook in the master branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10462: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10462:
URL: https://github.com/apache/airflow/pull/10462#issuecomment-678616048


   Nice - but you need to fix pylint failure :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] syudb commented on pull request #10462: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.
syudb commented on pull request #10462:
URL: https://github.com/apache/airflow/pull/10462#issuecomment-678661079


   No problem, rebased and pushed!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10462: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10462:
URL: https://github.com/apache/airflow/pull/10462#issuecomment-678660403


   There was a bad merge in master when the request war run - sorry for that but you will need to rebase :(


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10462: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10462:
URL: https://github.com/apache/airflow/pull/10462#issuecomment-679425273


   Cool @syudb . What's next ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10462: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10462:
URL: https://github.com/apache/airflow/pull/10462#issuecomment-679424986


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #10462: Updated REST API call so GET requests pass payload in query string instead of request body

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10462:
URL: https://github.com/apache/airflow/pull/10462


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org