[jira] Commented: (THRIFT-946) Augment FieldValueMetaData so it differentiates 'string' and 'binary' fields.

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918542#action_12918542 ] 

Bryan Duxbury commented on THRIFT-946:
--------------------------------------

Uh oh:

{code}
src/generate/t_java_generator.cc: In member function 'void t_java_generator::generate_field_value_meta_data(std::ofstream&, t_type*)':
src/generate/t_java_generator.cc:2115: error: 'class t_type' has no member named 'is_binary'
src/generate/t_java_generator.cc: In member function 'void t_java_generator::generate_java_struct_clear(std::ofstream&, t_struct*)':
src/generate/t_java_generator.cc:3900: warning: enumeration value 'TYPE_VOID' not handled in switch
src/generate/t_java_generator.cc:3900: warning: enumeration value 'TYPE_STRING' not handled in switch
make[1]: *** [thrift-t_java_generator.o] Error 1
make: *** [all] Error 2
{code}

> Augment FieldValueMetaData so it differentiates 'string' and 'binary' fields.
> -----------------------------------------------------------------------------
>
>                 Key: THRIFT-946
>                 URL: https://issues.apache.org/jira/browse/THRIFT-946
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler, Java - Library
>    Affects Versions: 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7
>            Reporter: Mathias Herberts
>            Priority: Minor
>         Attachments: THRIFT-946.patch
>
>
> String fields are not differentiated from binary fields in the meta data map. This is sometimes problematic when manipulating Thrift structs in tools such as Pig.
> The included patch extends FieldValueMetaData with 'isBinary' field and method and modifies the java compiler so generated code correctly reflects the binary nature of fields in the meta data.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.