You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/16 20:01:31 UTC
Review Request 13621: Added upgrade instructions for 0.14.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository: mesos-git
Description
-------
Also cherrypicked 0.13.0 upgrade instructions.
Diffs
-----
docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
Diff: https://reviews.apache.org/r/13621/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/#review25245
-----------------------------------------------------------
Ship it!
docs/Upgrades.md
<https://reviews.apache.org/r/13621/#comment49542>
I wouldn't say in favor of /health. Removing /vars and adding /health are orthogonal, but happen to both be present in 0.14.0. So maybe just mention that /vars no longer exists?
docs/Upgrades.md
<https://reviews.apache.org/r/13621/#comment49546>
Ditto, we should mention this in the changelog summary as well.
docs/Upgrades.md
<https://reviews.apache.org/r/13621/#comment49547>
Upgrade the scheduler to be setting FrameworkInfo.checkpoint, is this mandatory? Shouldn't we say if checkpointing is desired?
docs/Upgrades.md
<https://reviews.apache.org/r/13621/#comment49548>
It might not be totally clear what "upgrade" means here, install the new binaries without restarting the slaves?
e.g.
Upgrade the slaves (install the new slave binaries).
Would be great to cc Brenden on this or someone else who runs a cluster, to see how clear these instructions are. I'm biased so it seems intuitive for me but hard to tell how this may read to someone less familiar with upgrades. :)
- Ben Mahler
On Aug. 16, 2013, 6:02 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13621/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 6:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Thomas Marshall.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Also cherrypicked 0.13.0 upgrade instructions.
>
>
> Diffs
> -----
>
> docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
>
> Diff: https://reviews.apache.org/r/13621/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Tobias Weingartner <tw...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/#review25256
-----------------------------------------------------------
Ship it!
Ship It!
- Tobias Weingartner
On Aug. 16, 2013, 7:28 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13621/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 7:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, Joe Smith, Tobias Weingartner, and Thomas Marshall.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Also cherrypicked 0.13.0 upgrade instructions.
>
>
> Diffs
> -----
>
> docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
>
> Diff: https://reviews.apache.org/r/13621/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 16, 2013, 7:29 p.m., Brenden Matthews wrote:
> > Maybe also include some notes on how to use the recovery options?
good point. that will be in the CHANGELOG. will send out a review for that shortly.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/#review25251
-----------------------------------------------------------
On Aug. 16, 2013, 7:28 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13621/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 7:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, Joe Smith, Tobias Weingartner, and Thomas Marshall.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Also cherrypicked 0.13.0 upgrade instructions.
>
>
> Diffs
> -----
>
> docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
>
> Diff: https://reviews.apache.org/r/13621/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/#review25251
-----------------------------------------------------------
Ship it!
Maybe also include some notes on how to use the recovery options?
- Brenden Matthews
On Aug. 16, 2013, 7:28 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13621/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 7:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, Joe Smith, Tobias Weingartner, and Thomas Marshall.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Also cherrypicked 0.13.0 upgrade instructions.
>
>
> Diffs
> -----
>
> docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
>
> Diff: https://reviews.apache.org/r/13621/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/
-----------------------------------------------------------
(Updated Aug. 16, 2013, 7:28 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, Joe Smith, Tobias Weingartner, and Thomas Marshall.
Changes
-------
readded new reviewers since post-reviews doesnt seem to like them.
Repository: mesos-git
Description
-------
Also cherrypicked 0.13.0 upgrade instructions.
Diffs
-----
docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
Diff: https://reviews.apache.org/r/13621/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/
-----------------------------------------------------------
(Updated Aug. 16, 2013, 7:26 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's and joe's. NNFR.
Repository: mesos-git
Description
-------
Also cherrypicked 0.13.0 upgrade instructions.
Diffs (updated)
-----
docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
Diff: https://reviews.apache.org/r/13621/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/#review25247
-----------------------------------------------------------
Ship it!
Ship It!
- Brenden Matthews
On Aug. 16, 2013, 7:03 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13621/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 7:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, Joe Smith, Tobias Weingartner, and Thomas Marshall.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Also cherrypicked 0.13.0 upgrade instructions.
>
>
> Diffs
> -----
>
> docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
>
> Diff: https://reviews.apache.org/r/13621/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/#review25249
-----------------------------------------------------------
docs/Upgrades.md
<https://reviews.apache.org/r/13621/#comment49550>
Restart the slaves- add --checkpoint and --strict to enable checkpointing?
docs/Upgrades.md
<https://reviews.apache.org/r/13621/#comment49549>
Install new slave binaries and restart slave processes should be enough, I think
- Joe Smith
On Aug. 16, 2013, 7:03 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13621/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2013, 7:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, Joe Smith, Tobias Weingartner, and Thomas Marshall.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Also cherrypicked 0.13.0 upgrade instructions.
>
>
> Diffs
> -----
>
> docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
>
> Diff: https://reviews.apache.org/r/13621/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/
-----------------------------------------------------------
(Updated Aug. 16, 2013, 7:03 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, Joe Smith, Tobias Weingartner, and Thomas Marshall.
Changes
-------
added brenden, joe and toby to reviewers.
Repository: mesos-git
Description
-------
Also cherrypicked 0.13.0 upgrade instructions.
Diffs
-----
docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
Diff: https://reviews.apache.org/r/13621/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request 13621: Added upgrade instructions for 0.14.0.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13621/
-----------------------------------------------------------
(Updated Aug. 16, 2013, 6:02 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Thomas Marshall.
Changes
-------
adding thomas to the reviewers to confirm that upgrade instructions work with reservations code (disabled).
Repository: mesos-git
Description
-------
Also cherrypicked 0.13.0 upgrade instructions.
Diffs
-----
docs/Upgrades.md 71054828f1269f8eb7dafd495204ff3c154bc409
Diff: https://reviews.apache.org/r/13621/diff/
Testing
-------
Thanks,
Vinod Kone