You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/19 21:53:11 UTC
[GitHub] [openwhisk-wskdeploy] pwplusnick opened a new pull request #1091:
Support alt namespace uuid as tenant id on swagger api creates/deletes
pwplusnick opened a new pull request #1091: Support alt namespace uuid as tenant id on swagger api creates/deletes
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull
request #1091: Support alt namespace uuid as tenant id on swagger api
creates/deletes
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #1091: Support alt namespace uuid as tenant id on swagger api creates/deletes
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1091#discussion_r395701098
##########
File path: deployers/servicedeployer.go
##########
@@ -1014,9 +1014,9 @@ func (deployer *ServiceDeployer) createAction(pkgname string, action *whisk.Acti
func (deployer *ServiceDeployer) getAnnotationsFromPackageActionOrSequence(packageActionName string) *whisk.KeyValueArr {
- if len(packageActionName)!=0 {
+ if len(packageActionName) != 0 {
Review comment:
hehe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdeploy] mrutkows commented on a change in pull
request #1091: Support alt namespace uuid as tenant id on swagger api
creates/deletes
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #1091: Support alt namespace uuid as tenant id on swagger api creates/deletes
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1091#discussion_r395701409
##########
File path: deployers/servicedeployer.go
##########
@@ -1088,8 +1088,14 @@ func (deployer *ServiceDeployer) createSwaggerApi(api *whisk.ApiCreateRequest) e
var response *http.Response
apiCreateReqOptions := deployer.Deployment.SwaggerApiOptions
- apiCreateReqOptions.SpaceGuid = strings.Split(deployer.Client.Config.AuthToken, ":")[0]
apiCreateReqOptions.AccessToken = deployer.Client.Config.ApigwAccessToken
+ // In the case of IAM namespaces, we must use the ApigwTenantId as the SpaceGuid
Review comment:
Applying the same IAM token (securekey) logic here as we have added elsewhere... LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdeploy] mrutkows merged pull request #1091: Support
alt namespace uuid as tenant id on swagger api creates/deletes
Posted by GitBox <gi...@apache.org>.
mrutkows merged pull request #1091: Support alt namespace uuid as tenant id on swagger api creates/deletes
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1091
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services