You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/20 15:06:04 UTC

[GitHub] [apisix-dashboard] matkocsis opened a new issue, #2457: Consumer Plugin List: Added but Disabled Plugin Display Distinction

matkocsis opened a new issue, #2457:
URL: https://github.com/apache/apisix-dashboard/issues/2457

   ### Issue description
   
   There is no clean GUI distinction for a consumer plugin that is added but disabled on the plugin configuration page.
   
   Because of Plugin application precedence a higher level disabled plugin (consumer) still "applies" ( the disabled status ) if it is added, and disables / ignores the same lower level (Route) plugin configuration.
   
   
   ### Expected behavior
   
   On the Configure Consumer / Plugin Config page clearly visible difference between plugins that are not part of the consumer configuration vs 'Enabled / Added' but 'Disabled' by the check-box
   
   Possible solution would be to change the button label from "Enable" to "Edit (Disabled / Ignored)" for those plugins that are added but disabled to the consumer.
   So the 3 states would look like: Enable, Edit (Enabled), Edit(Disabled).
   
   ### How to Reproduce
   
   Step 1.
   - Route: configured with "basic-auth" + "limit-count" plugin.
   - Consumer: configured with "basic-auth" + "limit-count" plugin.
   
   Result:
   - Rate limiting works, and the setting is applied from the consumer config as per documentation.
   - On the Configure Consumer / Plugin Config page we could see the 2 plugins active: basic-auth, limit-count.
   
   Step 2.
   - Go to Configure Consumer / Plugin Config  -> limit-count plugin -> 'Edit' -> Switch off 'Enabled'
   
   Result: The plugin is still active, but disabled for this consumer, meaning there is no limit-count with that Auth (ignores the plugin from the Route). Takes precedence over the Route plugin, and gets it disabled / non-applied.
   
   I assume this is also an expected behavior, but it is impossible to differentiate which plugins are added but disabled on the Plugin Config list.
   
   
   ### Screenshots
   
   _No response_
   
   ### Environment
   
   - apisix version (cmd: `apisix version`): 
   - OS (cmd: `uname -a`): Linux
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `etcd --version`):
   - apisix-dashboard version, if have: 2.11.0
   - Browser version, if have:
   
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] jwrookie commented on issue #2457: Consumer Plugin List: Added but Disabled Plugin Display Distinction

Posted by GitBox <gi...@apache.org>.
jwrookie commented on issue #2457:
URL: https://github.com/apache/apisix-dashboard/issues/2457#issuecomment-1133539115

   Hi, @matkocsis  The plugins on `Consumer` and `Route` are merged by priority (`Consumer` > `Route`), according to the description you provided, `limit-count` is disabled on `Consumer` but `limit-count` on `Route`  is not effect , which is the expected behavior.
   
   If you want `limit-count` on `Route` to take effect, you need to remove `limit-count` from `Consumer`, not disable it
   
   Also at the moment you can't see its status on the plugin list, because there is no configure or disable share an enable button, you have to go to the details to find out


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] matkocsis commented on issue #2457: Consumer Plugin List: Added but Disabled Plugin Display Distinction

Posted by GitBox <gi...@apache.org>.
matkocsis commented on issue #2457:
URL: https://github.com/apache/apisix-dashboard/issues/2457#issuecomment-1133598352

   Hello @jwrookie Yes I know this is the right behaviour for the gateway. 
   My point in short is, that there is no clear distinction in the Configure Consumer / Plugin List page between an added but disabled vs not added Plugin.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] jwrookie commented on issue #2457: Consumer Plugin List: Added but Disabled Plugin Display Distinction

Posted by GitBox <gi...@apache.org>.
jwrookie commented on issue #2457:
URL: https://github.com/apache/apisix-dashboard/issues/2457#issuecomment-1133601044

   Yes, I agree with you that we should enhance it in the GUI
   We can discuss it in this issue https://github.com/apache/apisix-dashboard/issues/2354. Or send eamil to https://lists.apache.org/thread/lltjvf2bjj18og6no5lplwjry0z01pbd
   
   Thank you for your outstanding contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org