[GitHub] piiswrong commented on a change in pull request #8403: dtype default to source_array.dtype for sparse ndarrays

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #8403: dtype default to source_array.dtype for sparse ndarrays
URL: https://github.com/apache/incubator-mxnet/pull/8403#discussion_r146637061
 
 

 ##########
 File path: python/mxnet/ndarray/sparse.py
 ##########
 @@ -727,6 +727,18 @@ def _prepare_src_array(source_array, dtype):
             raise TypeError('values must be array like object')
     return source_array
 
+def _prepare_default_dtype(src_array, dtype):
+    """Prepare the value of dtype if `dtype` is None. If `src_array` is an NDArray, numpy.ndarray
+    or scipy.sparse.csr.csr_matrix, return src_array.dtype. float32 is returned otherwise."""
+    if dtype is None:
+        if isinstance(src_array, (NDArray, np.ndarray)):
+            dtype = src_array.dtype
+        elif spsp and isinstance(src_array, spsp.csr.csr_matrix):
 
 Review comment:
   shouldn't we raise an error if spsp is not available?
   Do we currently require scipy when using sparse?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services