You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ta...@apache.org on 2024/01/04 08:02:31 UTC

(myfaces) branch main updated: MYFACES-4647 fix NPE when the user does not have an active channel (#667)

This is an automated email from the ASF dual-hosted git repository.

tandraschko pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/myfaces.git


The following commit(s) were added to refs/heads/main by this push:
     new a6bef0eb5 MYFACES-4647  fix NPE when the user does not have an active channel (#667)
a6bef0eb5 is described below

commit a6bef0eb5d2d2c06fe9f70de3da9d0a29bb0fb97
Author: Milan Siebenbürger <mi...@gmail.com>
AuthorDate: Thu Jan 4 09:02:27 2024 +0100

    MYFACES-4647  fix NPE when the user does not have an active channel (#667)
---
 impl/src/main/java/org/apache/myfaces/push/cdi/PushContextImpl.java | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/impl/src/main/java/org/apache/myfaces/push/cdi/PushContextImpl.java b/impl/src/main/java/org/apache/myfaces/push/cdi/PushContextImpl.java
index 616d32cb5..f8e50899e 100644
--- a/impl/src/main/java/org/apache/myfaces/push/cdi/PushContextImpl.java
+++ b/impl/src/main/java/org/apache/myfaces/push/cdi/PushContextImpl.java
@@ -131,6 +131,12 @@ public class PushContextImpl implements PushContext
         for (S user : users)
         {
             Set<String> channelTokenSet = sessionManager.getChannelTokensForUser(user, channel);
+            if (channelTokenSet == null)
+            {
+                // no channel opened for this user
+                continue;
+            }
+
             Set<Future<Void>> results = new HashSet<>(channelTokenSet.size());
 
             for (String channelToken : channelTokenSet)