You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2016/01/02 22:01:29 UTC
[GitHub] metamodel pull request: METAMODEL-6: Added UpdateSummary building ...
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/84
METAMODEL-6: Added UpdateSummary building for JDBC module
Some more progress on METAMODEL-6. This adds support for the JDBC module to return number of inserts, updates, deletes and any generated keys. I chose the JDBC module because it is arguably the most complex. I imagine the reusing bits and pieces from here would be beneficial when implementing support in some of the other modules.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel METAMODEL-6/execute-update-return-value
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit d888907b3b27d821e0b8fd9291987e9b56e44c68
Author: Kasper Sørensen <i....@gmail.com>
Date: 2016-01-02T20:59:14Z
METAMODEL-6: Added UpdateSummary building for JDBC module
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-6: Added UpdateSummary building ...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/84#issuecomment-169632462
Would it make sense to also test the getUpdatedRows and the getDeletedRows methods in the test (deleting and updating some rows and checking these numbers)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-6: Added UpdateSummary building ...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/84#issuecomment-169997892
LGTM @kaspersorensen
Good job!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-6: Added UpdateSummary building ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/84#issuecomment-169988104
Yes it would :-) Let's do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-6: Added UpdateSummary building ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-6: Added UpdateSummary building ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/84#issuecomment-169992105
Added the assertions. Please re-review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---