You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Manoj Kasichainula <ma...@io.com> on 1999/11/03 08:53:47 UTC
Re: [PATCH] for PR# 4856 : problem with 1.3.9 mod_env module.
On Wed, Oct 27, 1999 at 02:41:17PM +0530, Jayaram A wrote:
> Please comment on the below fix the problem in mod_env module.
I don't know this module at all, but the patch seems okay to me.
BTW, please use unified diffs if you can. I know dev.apache.org says
to use -C3, but that's because many diff tools don't support -u.
> + if ( base->unsetenv ) {
> + new->unsetenv = (char *)ap_palloc(p, strlen(base->unsetenv)+1);
> + memcpy(new->unsetenv, base->unsetenv, strlen(base->unsetenv)+1);
> + } else
> + new->unsetenv = "";
> +
I guess this hunk fixes a problem where unsetenvs aren't inherited but
setenvs are?
--
Manoj Kasichainula - manojk at io dot com - http://www.io.com/~manojk/