[GitHub] couchdb-fabric pull request: Extend fetch ddoc logic for view filt...

[chewbranca <gi...@git.apache.org>]

Github user chewbranca commented on a diff in the pull request:

    https://github.com/apache/couchdb-fabric/pull/40#discussion_r54804058
  
    --- Diff: src/fabric_rpc.erl ---
    @@ -50,10 +50,15 @@ changes(DbName, Options, StartVector, DbOptions) ->
         Args0 = lists:keyfind(changes_args, 1, Options),
         #changes_args{dir=Dir, filter_fun=Filter} = Args0,
         Args = case Filter of
    -        {fetch, Style, Req, {DDocId, Rev}, FName} ->
    +        {fetch, FilterType, Style, Req, {DDocId, Rev}, FName} ->
                 {ok, DDoc} = ddoc_cache:open_doc(mem3:dbname(DbName), DDocId, Rev),
                 Args0#changes_args{
    -                filter_fun={custom, Style, Req, DDoc, FName}
    +                filter_fun={FilterType, Style, Req, DDoc, FName}
    +            };
    --- End diff --
    
    What do you think of making `FilterType` explicit here and match on `custom`? It's a little bit more awkward in the lower case given you can have `view` or `fast_view`, but I think it would make this it a bit more clear as to what the different cases are handling. I'm not attached to the idea though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---