You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/12/09 14:12:18 UTC

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables 

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16846


Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................

IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

PARTITION BY SPEC is only valid for Iceberg tables so Impala should
raise an error when it is used for non-Iceberg tables.

Testing
 * added e2e test

Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
2 files changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/16846/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................

IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

PARTITION BY SPEC is only valid for Iceberg tables so Impala should
raise an error when it is used for non-Iceberg tables.

Testing
 * added e2e test

Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Reviewed-on: http://gerrit.cloudera.org:8080/16846
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
2 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6771/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 12:23:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6770/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Sat, 12 Dec 2020 16:45:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Sat, 12 Dec 2020 16:45:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 15:08:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 20:47:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 1: Code-Review+1

This check is useful, LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Thu, 10 Dec 2020 09:02:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 15:09:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 2:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6771/


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 13:38:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7852/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 15:26:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Sat, 12 Dec 2020 10:38:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, wangsheng, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16846

to look at the new patch set (#3).

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................

IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

PARTITION BY SPEC is only valid for Iceberg tables so Impala should
raise an error when it is used for non-Iceberg tables.

Testing
 * added e2e test

Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
2 files changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/16846/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7807/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 09 Dec 2020 14:34:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6770/


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Sat, 12 Dec 2020 18:00:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16846 )

Change subject: IMPALA-10386: Don't allow PARTITION BY SPEC for non-Iceberg tables
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6772/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3ec3e84476614cb11e801b6d89d84eb384dd43
Gerrit-Change-Number: 16846
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 15:09:43 +0000
Gerrit-HasComments: No