You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Saxon Druce <sa...@blocksoftware.com> on 2002/06/02 09:27:54 UTC
Re: cvs commit: apr/file_io/win32 open.c pipe.c
----- Original Message -----
From: <wr...@apache.org>
To: <ap...@apache.org>
Sent: Thursday, May 30, 2002 1:25 PM
Subject: cvs commit: apr/file_io/win32 open.c pipe.c
> wrowe 02/05/29 22:25:00
>
> Modified: file_io/win32 open.c pipe.c
> Log:
> Modify our pipe semantics to match linux, such that at least 65536
bytes
> may be written to the pipe before it deadlocks. Matches our 1.3 fix.
>
> PR: 8179
>
> Revision Changes Path
> 1.101 +1 -0 apr/file_io/win32/open.c
>
> Index: open.c
> ===================================================================
> RCS file: /home/cvs/apr/file_io/win32/open.c,v
> retrieving revision 1.100
> retrieving revision 1.101
> diff -u -r1.100 -r1.101
> --- open.c 20 Mar 2002 08:54:43 -0000 1.100
> +++ open.c 30 May 2002 05:25:00 -0000 1.101
> @@ -519,6 +519,7 @@
> (*file)->filehand = *thefile;
> (*file)->ungetchar = -1; /* no char avail */
> (*file)->flags;
> + (*file)->pipe;
> return APR_SUCCESS;
> }
Shouldn't that be:
(*file)->pipe = <something>;
?
And the previous line should be:
(*file)->flags = flags;
(I submitted a patch for that one about 2 months ago).
cya,
Saxon Druce (saxon@blocksoftware.com)
Re: cvs commit: apr/file_io/win32 open.c pipe.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 02:21 PM 6/3/2002, you wrote:
>"William A. Rowe, Jr." <wr...@rowe-clan.net> writes:
>
> > That's a placeholder for an decision not made (I believe we apr_pcalloc,
> > so it isn't a huge issue between = 0 or omitting it entirely.)
>
>Oh right :) (To most people, it just looks like the same bug as with
>the flags line right above it.)
It is the same bug :-) I've just noted it as such.
Re: cvs commit: apr/file_io/win32 open.c pipe.c
Posted by Jeff Trawick <tr...@attglobal.net>.
"William A. Rowe, Jr." <wr...@rowe-clan.net> writes:
> That's a placeholder for an decision not made (I believe we apr_pcalloc,
> so it isn't a huge issue between = 0 or omitting it entirely.)
Oh right :) (To most people, it just looks like the same bug as with
the flags line right above it.)
--
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...
Re: cvs commit: apr/file_io/win32 open.c pipe.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
That's a placeholder for an decision not made (I believe we apr_pcalloc,
so it isn't a huge issue between = 0 or omitting it entirely.)
However, if we really were strict, we should call apr_file_info_get()
on the new file entity and set the pipe value based on the file type, no?
At 01:51 PM 6/3/2002, you wrote:
>"Saxon Druce" <sa...@blocksoftware.com> writes:
>
> > > Index: open.c
> > > ===================================================================
> > > RCS file: /home/cvs/apr/file_io/win32/open.c,v
> > > retrieving revision 1.100
> > > retrieving revision 1.101
> > > diff -u -r1.100 -r1.101
> > > --- open.c 20 Mar 2002 08:54:43 -0000 1.100
> > > +++ open.c 30 May 2002 05:25:00 -0000 1.101
> > > @@ -519,6 +519,7 @@
> > > (*file)->filehand = *thefile;
> > > (*file)->ungetchar = -1; /* no char avail */
> > > (*file)->flags;
> > > + (*file)->pipe;
> > > return APR_SUCCESS;
> > > }
> >
> > Shouldn't that be:
> >
> > (*file)->pipe = <something>;
>
>Definitely should be changed, even though it works fine now.
>apr_os_file_put() assumes that it is a pipe, so it should be
>
> (*file)->pipe = 0;
>
>or the code can simply be omitted since the structure is cleared.
>
> > And the previous line should be:
> >
> > (*file)->flags = flags;
> >
> > (I submitted a patch for that one about 2 months ago).
>
>if no Win32 committer speaks up/commits soon, I'll do it myself,
>albeit with no test-compile
>
>Thanks for persisting!!!!!
>
>--
>Jeff Trawick | trawick@attglobal.net
>Born in Roswell... married an alien...
Re: cvs commit: apr/file_io/win32 open.c pipe.c
Posted by Jeff Trawick <tr...@attglobal.net>.
"Saxon Druce" <sa...@blocksoftware.com> writes:
> > Index: open.c
> > ===================================================================
> > RCS file: /home/cvs/apr/file_io/win32/open.c,v
> > retrieving revision 1.100
> > retrieving revision 1.101
> > diff -u -r1.100 -r1.101
> > --- open.c 20 Mar 2002 08:54:43 -0000 1.100
> > +++ open.c 30 May 2002 05:25:00 -0000 1.101
> > @@ -519,6 +519,7 @@
> > (*file)->filehand = *thefile;
> > (*file)->ungetchar = -1; /* no char avail */
> > (*file)->flags;
> > + (*file)->pipe;
> > return APR_SUCCESS;
> > }
>
> Shouldn't that be:
>
> (*file)->pipe = <something>;
Definitely should be changed, even though it works fine now.
apr_os_file_put() assumes that it is a pipe, so it should be
(*file)->pipe = 0;
or the code can simply be omitted since the structure is cleared.
> And the previous line should be:
>
> (*file)->flags = flags;
>
> (I submitted a patch for that one about 2 months ago).
if no Win32 committer speaks up/commits soon, I'll do it myself,
albeit with no test-compile
Thanks for persisting!!!!!
--
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...