You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/03 19:23:39 UTC

[GitHub] [nifi] NissimShiman commented on pull request #5878: NIFI-9814: Add Range Sampling strategy to SampleRecord

NissimShiman commented on PR #5878:
URL: https://github.com/apache/nifi/pull/5878#issuecomment-1204380413

   Just noticed this was still open ... 
   
   Follow commit looks good.  Nice catch with additional @WriteAttributes of mime.count
   Verified that it is indeed added on flowfile output
   and nice cleaning up of customValidate() based on new .dependsOn() for the various PropertyDescriptors
   
   I apologize if this was waiting on comment following up on the latter commit
   LGTM +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org