You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tnachen <gi...@git.apache.org> on 2016/06/02 17:11:23 UTC

[GitHub] spark pull request #13326: [SPARK-15560] [Mesos] Queued/Supervise drivers wa...

Github user tnachen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13326#discussion_r65580076
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala ---
    @@ -188,10 +188,10 @@ private[spark] class MesosClusterScheduler(
             mesosDriver.killTask(task.taskId)
             k.success = true
             k.message = "Killing running driver"
    -      } else if (removeFromQueuedDrivers(submissionId)) {
    --- End diff --
    
    We should just rename and change the existing function, I Don't think it's being used elsewhere?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org