You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/03 12:04:31 UTC

[GitHub] [flink] zentol opened a new pull request #13053: [FLINK-18805][config] Improve handling of upper-character sequences 

zentol opened a new pull request #13053:
URL: https://github.com/apache/flink/pull/13053


   Based on #13052.
   
   The ConfigDocsGenerator generates a file name (generally) based on the name of the class containing the options. When this name contains multiple upper characters in sequence, like `JMXOptions`, then it currently does not properly separate the sequence (jmx) from the last word (options), resulting in `j_mx_options`.
   
   This PR makes a small change such that we split the string before the last upper character.
   
   See the added test case (`ConfigOptionsDocGenerator#testSnakeCaseConversion`)  for which cases this accounts for.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #13053: [FLINK-18805][config] Improve handling of upper-character sequences

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #13053:
URL: https://github.com/apache/flink/pull/13053


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13053: [FLINK-18805][config] Improve handling of upper-character sequences

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13053:
URL: https://github.com/apache/flink/pull/13053#issuecomment-667994938


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eff5113e050a4c660a8bfeb2964815c91cd96dad",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5123",
       "triggerID" : "eff5113e050a4c660a8bfeb2964815c91cd96dad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eff5113e050a4c660a8bfeb2964815c91cd96dad Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5123) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13053: [FLINK-18805][config] Improve handling of upper-character sequences

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13053:
URL: https://github.com/apache/flink/pull/13053#issuecomment-667986532


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit eff5113e050a4c660a8bfeb2964815c91cd96dad (Mon Aug 03 12:07:23 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13053: [FLINK-18805][config] Improve handling of upper-character sequences

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13053:
URL: https://github.com/apache/flink/pull/13053#issuecomment-667994938


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "eff5113e050a4c660a8bfeb2964815c91cd96dad",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "eff5113e050a4c660a8bfeb2964815c91cd96dad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * eff5113e050a4c660a8bfeb2964815c91cd96dad UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org