You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/28 04:33:56 UTC

[GitHub] [spark] dchvn opened a new pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

dchvn opened a new pull request #34413:
URL: https://github.com/apache/spark/pull/34413


   ### What changes were proposed in this pull request?
   Inline type hints for python/pyspark/resultiterable.py
   
   
   ### Why are the changes needed?
   We can take advantage of static type checking within the functions by inlining the type hints.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Existing tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953509068


   **[Test build #144693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144693/testReport)** for PR 34413 at commit [`e073a8e`](https://github.com/apache/spark/commit/e073a8eff8bad78b459fb05833768b58c0d16966).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dchvn commented on a change in pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
dchvn commented on a change in pull request #34413:
URL: https://github.com/apache/spark/pull/34413#discussion_r738869876



##########
File path: python/pyspark/resultiterable.py
##########
@@ -15,26 +15,31 @@
 # limitations under the License.
 #
 
-from collections.abc import Iterable
+from typing import TypeVar, TYPE_CHECKING, Type, Iterator
+
+if TYPE_CHECKING:
+    from pyspark._typing import SizedIterable
 
 
 __all__ = ["ResultIterable"]
 
+T = TypeVar("T")
+
 
-class ResultIterable(Iterable):
+class ResultIterable(Type["SizedIterable[T]"]):  # type: ignore[misc]

Review comment:
       Thank you, @HyukjinKwon, @zero323. I updated as your suggestion. Can you take another look, please?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953785180


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49178/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-954834086


   Thanks everyone!
   
   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953785180


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49178/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953531853


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144693/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953707313


   **[Test build #144709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144709/testReport)** for PR 34413 at commit [`ae6fce8`](https://github.com/apache/spark/commit/ae6fce8e1892dd2bf2f9cbeccdd1cf7bad9ef383).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953744681


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144709/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953707313


   **[Test build #144709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144709/testReport)** for PR 34413 at commit [`ae6fce8`](https://github.com/apache/spark/commit/ae6fce8e1892dd2bf2f9cbeccdd1cf7bad9ef383).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953531853


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144693/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953524733


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49162/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34413:
URL: https://github.com/apache/spark/pull/34413#discussion_r738051471



##########
File path: python/pyspark/resultiterable.py
##########
@@ -15,26 +15,31 @@
 # limitations under the License.
 #
 
-from collections.abc import Iterable
+from typing import TypeVar, TYPE_CHECKING, Type, Iterator
+
+if TYPE_CHECKING:
+    from pyspark._typing import SizedIterable
 
 
 __all__ = ["ResultIterable"]
 
+T = TypeVar("T")
+
 
-class ResultIterable(Iterable):
+class ResultIterable(Type["SizedIterable[T]"]):  # type: ignore[misc]

Review comment:
       why did we ignore this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953727971


   **[Test build #144709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144709/testReport)** for PR 34413 at commit [`ae6fce8`](https://github.com/apache/spark/commit/ae6fce8e1892dd2bf2f9cbeccdd1cf7bad9ef383).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `class ResultIterable(Iterable[T]):`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dchvn commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-955126115


   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953746101


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49178/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on a change in pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34413:
URL: https://github.com/apache/spark/pull/34413#discussion_r738171591



##########
File path: python/pyspark/resultiterable.py
##########
@@ -15,26 +15,31 @@
 # limitations under the License.
 #
 
-from collections.abc import Iterable
+from typing import TypeVar, TYPE_CHECKING, Type, Iterator
+
+if TYPE_CHECKING:
+    from pyspark._typing import SizedIterable
 
 
 __all__ = ["ResultIterable"]
 
+T = TypeVar("T")
+
 
-class ResultIterable(Iterable):
+class ResultIterable(Type["SizedIterable[T]"]):  # type: ignore[misc]

Review comment:
       This just doesn't look right.  If anything, it should be `class ResultIterable("SizedIterable[T]")`, but we can _probably_ skip it whatsoever and  use `Iterable[T]`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953563602


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49162/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953519940


   **[Test build #144693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144693/testReport)** for PR 34413 at commit [`e073a8e`](https://github.com/apache/spark/commit/e073a8eff8bad78b459fb05833768b58c0d16966).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953744681


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144709/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953555650


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49162/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 closed pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #34413:
URL: https://github.com/apache/spark/pull/34413


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953775495


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49178/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953509068


   **[Test build #144693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144693/testReport)** for PR 34413 at commit [`e073a8e`](https://github.com/apache/spark/commit/e073a8eff8bad78b459fb05833768b58c0d16966).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953535391


   cc @zero323 FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34413: [SPARK-37140][PYTHON] Inline type hints for python/pyspark/resultiterable.py

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34413:
URL: https://github.com/apache/spark/pull/34413#issuecomment-953563602


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49162/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org