[GitHub] spark pull request #16579: [WIP][SPARK-19218][SQL] SET command should show a...

[dongjoon-hyun <gi...@git.apache.org>]

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16579#discussion_r96509362
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala ---
    @@ -79,7 +79,7 @@ case class SetCommand(kv: Option[(String, Option[String])]) extends RunnableComm
         // Queries all key-value pairs that are set in the SQLConf of the sparkSession.
         case None =>
           val runFunc = (sparkSession: SparkSession) => {
    -        sparkSession.conf.getAll.map { case (k, v) => Row(k, v) }.toSeq
    +        sparkSession.conf.getAll.map { case (k, v) => Row(k, v) }.toSeq.sortBy(_.getString(0))
    --- End diff --
    
    Oh, @gatorsmile . I missed your comment. The return value from `sql("set -v")` seems not to be safe. I think there may be some synchronization issue here. I'll create a separate PR for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org