[GitHub] [brooklyn-ui] iuliana commented on a change in pull request #258: Display icon in DSL editor search result only if there is one

[GitBox <gi...@apache.org>]

iuliana commented on a change in pull request #258:
URL: https://github.com/apache/brooklyn-ui/pull/258#discussion_r682379145



##########
File path: ui-modules/blueprint-composer/app/components/dsl-editor/dsl-editor.template.html
##########
@@ -62,7 +62,7 @@ <h4 class="list-group-item-heading">
                     {{item.name}}
                 </h4>
                 <p class="list-group-item-entity text-right text-muted">
-                    <img ng-src="{{item.entity.icon}}" alt="{{item.entity.miscData.get('typeName') || (item.entity | entityName) || 'New application'}} logo" class="list-group-item-entity-icon" />
+                    <img ng-if="item.entity.icon" ng-src="{{item.entity.icon}}" class="list-group-item-entity-icon"/>

Review comment:
       This looks a lot cleaner. I like it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org