[GitHub] [hadoop] steveloughran commented on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…

[GitBox <gi...@apache.org>]

steveloughran commented on issue #1222: HADOOP-16488 Deprecated JsonSerialization and move it out of hadoop-c…
URL: https://github.com/apache/hadoop/pull/1222#issuecomment-518018384
 
 
   1. your IDE has gone overboard with reorganising the imports, which makes reviewing too hard. can you revert those changes so there's something more minimal.
   1. If we can move all internal code off json serialization then there's no need to retain that class at all. it's private and not AFAIK used externally (it only got moved from hadoop-registry to hadoop-common with Hadoop 3.1, after all.
   
   >. And for hadoop-aws, maybe we can just move copy some code for JsonSerialization there, as the java sdk for aws depends on jackson so it is useless to purge the jackson dependency for it.
   
   AWS SDK is shaded; their problem. We need to get hadoop-aws off it, which is doable. 
   
   Hadoop-registry is the origin of this code; need to review that to make sure the records persistet can be marshalled without problems
   
   For all the changes, I think we should add tests verifying consistent loading of existing classes first. That is: we save the current .json files as test resources and verify that they can be loaded with the new code. That's a good practise anyway, isn't it? 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org