[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

["David Ribeiro Alves (Code Review)" <ge...@cloudera.org>]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5320

to look at the new patch set (#3).

Change subject: KUDU-625 - Make write transactions abort in mvcc, by default
......................................................................

KUDU-625 - Make write transactions abort in mvcc, by default

This patch addresses a long standing TODO where we would commit
transactions on the WriteTransactionState dctor instead of
aborting them, if they hadn't been explicitely
committed/aborted.

Besides changing WriteTransactionState::Reset() to call
CommitOrAbort(Transaction::ABORTED) this also required a change
to TabletBootstrap to explicitely call
tx_state.CommitOrAbort(Transaction::COMMITTED) in
PlayWriteRequest().

I ran raft_consensus-itest and exactly_once_writes-itest in slow
mode, asan, for 1000 loops on dist-test. No failures.
Results:

exactly_once_writes-itest: http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678
raft_consensus-itest     : http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678

Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
---
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/transactions/write_transaction.cc
2 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/5320/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>