You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Rodrigo Schmidt (JIRA)" <ji...@apache.org> on 2010/04/21 02:55:50 UTC
[jira] Created: (HADOOP-6719) Missing methods on FilterFs
Missing methods on FilterFs
---------------------------
Key: HADOOP-6719
URL: https://issues.apache.org/jira/browse/HADOOP-6719
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Rodrigo Schmidt
Assignee: Rodrigo Schmidt
Fix For: 0.22.0
The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
Here is the complete list:
{code}
{
public FSDataInputStream open(final Path f) { return null; }
public void checkPath(Path path) { }
public Statistics getStatistics() { return null; }
public URI getUri() { return null; }
public Path getHomeDirectory() { return null; }
public void checkScheme(URI uri, String supportedScheme) { }
public String getUriPath(final Path p) { return null; }
public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
public FsStatus getFsStatus(final Path f) { return null; }
}
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6719) Missing methods on FilterFs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859158#action_12859158 ]
Hadoop QA commented on HADOOP-6719:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442378/HADOOP-6719.0.patch
against trunk revision 934619.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/45/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/45/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/45/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/45/console
This message is automatically generated.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Status: Patch Available (was: Open)
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch, HADOOP-6719.3.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Status: Patch Available (was: Open)
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6719) Missing methods on FilterFs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859284#action_12859284 ]
Hadoop QA commented on HADOOP-6719:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442401/HADOOP-6719.2.patch
against trunk revision 934619.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/469/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/469/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/469/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/469/console
This message is automatically generated.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-6719:
-------------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
I just committed this. Thanks Rodrigo!
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch, HADOOP-6719.3.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6719) Missing methods on FilterFs
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859179#action_12859179 ]
Eli Collins commented on HADOOP-6719:
-------------------------------------
Forgot to mention in the patch DontCheck should be removed and the necessary methods overridden in FilterFs.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6719) Missing methods on FilterFs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859540#action_12859540 ]
Hadoop QA commented on HADOOP-6719:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442481/HADOOP-6719.3.patch
against trunk revision 936463.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/471/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/471/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/471/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/471/console
This message is automatically generated.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch, HADOOP-6719.3.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Status: Open (was: Patch Available)
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Attachment: HADOOP-6719.1.patch
Following Eli's suggestions.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Status: Patch Available (was: Open)
Took checkScheme() out of FilterFs
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Attachment: HADOOP-6719.3.patch
Eclipse had added a bad import to the file. Submitting a new patch.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch, HADOOP-6719.3.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6719) Missing methods on FilterFs
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859208#action_12859208 ]
Hadoop QA commented on HADOOP-6719:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442395/HADOOP-6719.1.patch
against trunk revision 934619.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/47/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/47/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/47/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/47/console
This message is automatically generated.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Status: Patch Available (was: Open)
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Attachment: HADOOP-6719.0.patch
Unit test that passes with the current implementation of FilterFs, but might have to be modified if we decide some of the missing methods should be there.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6719) Missing methods on FilterFs
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859559#action_12859559 ]
Eli Collins commented on HADOOP-6719:
-------------------------------------
+1 Looks good.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch, HADOOP-6719.3.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Attachment: HADOOP-6719.2.patch
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Status: Open (was: Patch Available)
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859233#action_12859233 ]
Rodrigo Schmidt commented on HADOOP-6719:
-----------------------------------------
Implementing checkScheme inside FilterFs has broken 128 unit tests. I'm taking it out and trying again.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6719) Missing methods on FilterFs
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-6719:
------------------------------------
Status: Open (was: Patch Available)
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch, HADOOP-6719.1.patch, HADOOP-6719.2.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6719) Missing methods on FilterFs
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859178#action_12859178 ]
Eli Collins commented on HADOOP-6719:
-------------------------------------
My understanding is that FilterFs should override all AFS methods, the FilterFs javadoc concurs: "The class <code>FilterFs</code> itself simply overrides all methods of <code>AbstractFileSystem</code> with versions that pass all requests to the contained file system." It currently gets away with not overriding these because its subclasses, ChecksumFs and LocalFs, don't need to override them.
> Missing methods on FilterFs
> ---------------------------
>
> Key: HADOOP-6719
> URL: https://issues.apache.org/jira/browse/HADOOP-6719
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: HADOOP-6719.0.patch
>
>
> The following methods are not declared on FilterFs(). Some of them are fine, but others like getUri(), getStatistics(), getHomeDirectory() look like they should be there.
> Here is the complete list:
> {code}
> {
> public FSDataInputStream open(final Path f) { return null; }
> public void checkPath(Path path) { }
> public Statistics getStatistics() { return null; }
> public URI getUri() { return null; }
> public Path getHomeDirectory() { return null; }
> public void checkScheme(URI uri, String supportedScheme) { }
> public String getUriPath(final Path p) { return null; }
> public void renameInternal(final Path src, final Path dst, boolean overwrite) { }
> public FsStatus getFsStatus(final Path f) { return null; }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.