[jira] [Commented] (MESOS-994) Add an Option os::getenv() to stout

["Greg Mann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517566#comment-14517566 ] 

Greg Mann commented on MESOS-994:
---------------------------------

This is the first issue I've assigned to myself in Mesos. I wrote a test and it failed when run. I added a new "Option<string> getenv(Option<string>&)", and then had to create one more version overloaded for const char* to disambiguate calls in libprocess to os::getenv(const char*) and similar datatypes. Mesos now compiles and "make check" completes successfully.

If this all sounds good, I'm currently figuring out how to properly submit a patch to Mesos.

> Add an Option<string> os::getenv() to stout
> -------------------------------------------
>
>                 Key: MESOS-994
>                 URL: https://issues.apache.org/jira/browse/MESOS-994
>             Project: Mesos
>          Issue Type: Improvement
>          Components: stout, technical debt
>            Reporter: Ian Downes
>            Assignee: Greg Mann
>              Labels: newbie
>
> This would replace the common pattern of:
> Option<string> = os::hasenv() ? Option<string>(os::getenv()) : None()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)