You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2023/05/08 17:59:33 UTC
[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin opened a new pull request, #8: SLING-11866 add failing test case to show that not all default
kwin opened a new pull request, #8:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/8
properties are stripped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin closed pull request #8: SLING-11866 add failing test case to show that not all default
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin closed pull request #8: SLING-11866 add failing test case to show that not all default
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin commented on pull request #8: SLING-11866 add failing test case to show that not all default
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #8:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/8#issuecomment-1539002088
Which SPI is then supposed to be used to filter out merged config properties? (I only found methods in bundle private packages) And why are merged config properties still somehow considered in MetatypeHandler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin commented on pull request #8: SLING-11866 add failing test case to show that not all default
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #8:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/8#issuecomment-1545290389
Clarified meanwhile in https://issues.apache.org/jira/browse/SLING-10771.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin commented on pull request #8: SLING-11866 add failing test case to show that not all default
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #8:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/8#issuecomment-1538805101
@cziegeler Can you confirm that my expectation is correct? As `MetatypeHandler.updateConfiguration()` is the only method actually modifying the configuration properties it must IMHO treat both Metatype default values and Merge configuration values, otherwise `WebconsoleConfigurationHandler` will not any effect for the latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-installer-factory-configuration] cziegeler commented on pull request #8: SLING-11866 add failing test case to show that not all default
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #8:
URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/8#issuecomment-1538966586
I think your expectation is wrong :) the merge props are most likely handled somewhere else.
You can do an end to end test and see whether everything is handled correctly; it should
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org