You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2017/01/13 21:35:51 UTC
Review Request 55522: Incorrect error message when trying to add a
group to multiple roles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55522/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-19476
https://issues.apache.org/jira/browse/AMBARI-19476
Repository: ambari
Description
-------
1. Create a group and assign roles to the group.
2. If you add the same group to multiple roles, the error message says "Only 1 role allowed per user".
Updated the error message to say users or groups.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js a01324b
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js c170235
Diff: https://reviews.apache.org/r/55522/diff/
Testing
-------
Manual test verification.
Ran mvn test.
Thanks,
Sangeeta Ravindran
Re: Review Request 55522: Incorrect error message when trying to add
a group to multiple roles
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55522/#review161599
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On Jan. 13, 2017, 9:35 p.m., Sangeeta Ravindran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55522/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 9:35 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Di Li.
>
>
> Bugs: AMBARI-19476
> https://issues.apache.org/jira/browse/AMBARI-19476
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Create a group and assign roles to the group.
> 2. If you add the same group to multiple roles, the error message says "Only 1 role allowed per user".
>
> Updated the error message to say users or groups.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js a01324b
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/PermissionsSaver.js c170235
>
> Diff: https://reviews.apache.org/r/55522/diff/
>
>
> Testing
> -------
>
> Manual test verification.
> Ran mvn test.
>
>
> Thanks,
>
> Sangeeta Ravindran
>
>