You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/23 09:31:18 UTC

[GitHub] [maven-parent] gnodet commented on pull request #82: [MPOM-349] Apply spotless to check/reformat code + poms

gnodet commented on PR #82:
URL: https://github.com/apache/maven-parent/pull/82#issuecomment-1288064676

   > LGTM but if we move to spotless. I would remove `checkstyle:check` as well as we do not need really to check sources style twice during the build....
   > And it's a bit confusing as when testing this pom with m-war-p, `checkstyle:check` is passing but not `spotless:check'
   
   @olamy Checkstyle checks method length, file length, qualifier order, parameter numbers, field/method ordering, etc...  Those won't be checked by pure code style validation.  I don't really see the value for removing those checks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org