You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/08 13:50:40 UTC

[GitHub] [flink] matriv opened a new pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

matriv opened a new pull request #17439:
URL: https://github.com/apache/flink/pull/17439


   ## What is the purpose of the change
   
   Following discussions on the issue and the relevant calcite issue: CALCITE-4777
   the support for decimal numerics is dropped, and only from integer numerics
   (TINYINT, SMALLINT, INT, BIGINT) remains as is.
   
   
   ## Brief change log
   
     - Drop support for casting DECIMAL/FLOAT/DOUBLE to BOOLEAN
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added tests to `CastFunctionITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr commented on a change in pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r730838887



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
##########
@@ -411,7 +411,7 @@ public String toString() {
             return "[API] "
                     + expression.stream()
                             .map(Expression::asSummaryString)
-                            .collect(Collectors.joining());
+                            .collect(Collectors.joining(", "));

Review comment:
       usually, our commit tags should describe the Maven module that they touch mostly, so for the hotfix commit it woul d be `[hotfix][table-planner]`, `[test]` sounds more like `flink-tests`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25219",
       "triggerID" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "711c3b24a34da8fbc1065487b3815599a7c25af7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "711c3b24a34da8fbc1065487b3815599a7c25af7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174) 
   * 5af68936a0eec1623b38a5f73ba5f5e9d62e387a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25219) 
   * 711c3b24a34da8fbc1065487b3815599a7c25af7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25219",
       "triggerID" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174) 
   * 5af68936a0eec1623b38a5f73ba5f5e9d62e387a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25219) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174) 
   * 5af68936a0eec1623b38a5f73ba5f5e9d62e387a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b5929ea88fffdb3c019dce8034cd540ded7ac025 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper commented on a change in pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r727828034



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -894,6 +891,13 @@ protected Configuration configuration() {
         private final List<Object> columnData = new ArrayList<>();
         private final List<AbstractDataType<?>> columnTypes = new ArrayList<>();
         private final List<Object> expectedValues = new ArrayList<>();
+        private final List<TestType> testTypes = new ArrayList<>();
+
+        private enum TestType {
+            RESULT,
+            ERROR_SQL,
+            ERROR_TABLE_API

Review comment:
       Why the test case does any distinction between error in SQL and Table API? Isn't a cast invalid both for SQL and Table API? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] matriv commented on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-940996977


   @twalthr I changed the `fail` to `failTableApi` to make it visible that it's only for that.
   
   - Should I keep a comment pointing to the same issue since we want to test also for SQL once calcite PR is merged and adopted, or create a new issue just for that (and still keep a comment pointing to it)?
   - Please don't forget that this is a breaking change since currently those casts where allowed (proper label?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper commented on a change in pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r727828034



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -894,6 +891,13 @@ protected Configuration configuration() {
         private final List<Object> columnData = new ArrayList<>();
         private final List<AbstractDataType<?>> columnTypes = new ArrayList<>();
         private final List<Object> expectedValues = new ArrayList<>();
+        private final List<TestType> testTypes = new ArrayList<>();
+
+        private enum TestType {
+            RESULT,
+            ERROR_SQL,
+            ERROR_TABLE_API

Review comment:
       Why the test case does any distinction between error in SQL and Table API? Isn't a cast invalid both for SQL and Table API? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] matriv commented on a change in pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r727117352



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
##########
@@ -411,7 +411,7 @@ public String toString() {
             return "[API] "
                     + expression.stream()
                             .map(Expression::asSummaryString)
-                            .collect(Collectors.joining());
+                            .collect(Collectors.joining(", "));

Review comment:
       Done, thx!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b5929ea88fffdb3c019dce8034cd540ded7ac025 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860) 
   * 2b821c46c8ac9285981b41272726fe87d7a03566 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] matriv commented on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-945780170


   Thx @twalthr, created FLINK-24576, linked to calcite's upgrade and added a reminder comment on top of the corresponding cast tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr commented on a change in pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r726903584



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
##########
@@ -411,7 +411,7 @@ public String toString() {
             return "[API] "
                     + expression.stream()
                             .map(Expression::asSummaryString)
-                            .collect(Collectors.joining());
+                            .collect(Collectors.joining(", "));

Review comment:
       changes in test bases that are unrelated to the PR, should be moved in a hotfix commit. this way a committer can still merge this, even if we discard the main commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938661631


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b5929ea88fffdb3c019dce8034cd540ded7ac025 (Fri Oct 08 13:53:06 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-23271).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] matriv commented on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-946779757


   > Sorry, I have one last comment. Should be good afterwards.
   
   No worries! Fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr commented on a change in pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r731888330



##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/TypeCheckUtils.java
##########
@@ -45,6 +45,10 @@ public static boolean isNumeric(LogicalType type) {
         return type.getTypeRoot().getFamilies().contains(LogicalTypeFamily.NUMERIC);
     }
 
+    public static boolean isIntegerNumeric(LogicalType type) {

Review comment:
       use `LogicalTypeChecks.hasFamily()` instead? we should avoid introducing to many utilities that basically do the same thing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] matriv commented on a change in pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17439:
URL: https://github.com/apache/flink/pull/17439#discussion_r730929176



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
##########
@@ -411,7 +411,7 @@ public String toString() {
             return "[API] "
                     + expression.stream()
                             .map(Expression::asSummaryString)
-                            .collect(Collectors.joining());
+                            .collect(Collectors.joining(", "));

Review comment:
       Fixed the commit message, thx!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] matriv commented on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938661620


   TODO:
   - Wait for https://github.com/apache/calcite/pull/2555 to be merged and either wait for new release or adopt the `SqlTypeCoercionRule` functionality
   - Test that error is thrown also in case of SQL (not just TableAPI)
   - Remove unused code, i.e.: from `ScalarOperatorGens` related to the now unsupported cast


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] matriv commented on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-946740001


   @twalthr Could you please check again? I changed some code in the code generator regarding the numeric cast to boolean and adjusted a few more tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr closed pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17439:
URL: https://github.com/apache/flink/pull/17439


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25219",
       "triggerID" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "711c3b24a34da8fbc1065487b3815599a7c25af7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25226",
       "triggerID" : "711c3b24a34da8fbc1065487b3815599a7c25af7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5af68936a0eec1623b38a5f73ba5f5e9d62e387a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25219) 
   * 711c3b24a34da8fbc1065487b3815599a7c25af7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25226) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b5929ea88fffdb3c019dce8034cd540ded7ac025 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860) 
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b5929ea88fffdb3c019dce8034cd540ded7ac025 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25219",
       "triggerID" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "711c3b24a34da8fbc1065487b3815599a7c25af7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25226",
       "triggerID" : "711c3b24a34da8fbc1065487b3815599a7c25af7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174) 
   * 5af68936a0eec1623b38a5f73ba5f5e9d62e387a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25219) 
   * 711c3b24a34da8fbc1065487b3815599a7c25af7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25226) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25219",
       "triggerID" : "5af68936a0eec1623b38a5f73ba5f5e9d62e387a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "711c3b24a34da8fbc1065487b3815599a7c25af7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25226",
       "triggerID" : "711c3b24a34da8fbc1065487b3815599a7c25af7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 711c3b24a34da8fbc1065487b3815599a7c25af7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25226) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171) 
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b821c46c8ac9285981b41272726fe87d7a03566 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986) 
   * 5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24986",
       "triggerID" : "2b821c46c8ac9285981b41272726fe87d7a03566",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25171",
       "triggerID" : "5dc78cd2cb8ec6dc971f05c75cbc9b33001e1fe5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174",
       "triggerID" : "57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 57a13401fc3f49a09bc7b5770f1e7aa212a1b6f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25174) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17439: [FLINK-23271][table-planner] Disallow cast from decimal numerics to boolean

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17439:
URL: https://github.com/apache/flink/pull/17439#issuecomment-938696330


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860",
       "triggerID" : "b5929ea88fffdb3c019dce8034cd540ded7ac025",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b5929ea88fffdb3c019dce8034cd540ded7ac025 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24860) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org