You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Jean-Daniel Cryans <jd...@apache.org> on 2011/10/07 02:26:14 UTC
"expecting X results" spam
Hey devs,
I was testing out 0.92 and HCM got this like this a year ago:
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("expecting "+results.length+" results");
+ }
coming from HBASE-2002 (it's triggered for every processBatchCallback). Was
it intentional? It sure is at DEBUG but since we ship at that logging level
I would suggest removing it.
J-D
Re: "expecting X results" spam
Posted by Gary Helmling <gh...@gmail.com>.
+1 to removing it
It was intentional at one point... :)
But that doesn't mean it should have stayed in the final patch for commit.
On Thu, Oct 6, 2011 at 5:26 PM, Jean-Daniel Cryans <jd...@apache.org>wrote:
> Hey devs,
>
> I was testing out 0.92 and HCM got this like this a year ago:
>
> + if (LOG.isDebugEnabled()) {
> + LOG.debug("expecting "+results.length+" results");
> + }
>
> coming from HBASE-2002 (it's triggered for every processBatchCallback). Was
> it intentional? It sure is at DEBUG but since we ship at that logging level
> I would suggest removing it.
>
> J-D
>
Re: "expecting X results" spam
Posted by Andrew Purtell <ap...@apache.org>.
Concur, pretty sure I removed this from our internal build, and if not will do so right now.
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
>________________________________
>From: Ted Yu <yu...@gmail.com>
>To: "dev@hbase.apache.org" <de...@hbase.apache.org>
>Cc: "dev@hbase.apache.org" <de...@hbase.apache.org>
>Sent: Friday, October 7, 2011 8:33 AM
>Subject: Re: "expecting X results" spam
>
>+1 on removing it.
>
>
>
>On Oct 6, 2011, at 5:26 PM, Jean-Daniel Cryans <jd...@apache.org> wrote:
>
>> Hey devs,
>>
>> I was testing out 0.92 and HCM got this like this a year ago:
>>
>> + if (LOG.isDebugEnabled()) {
>> + LOG.debug("expecting "+results.length+" results");
>> + }
>>
>> coming from HBASE-2002 (it's triggered for every processBatchCallback). Was
>> it intentional? It sure is at DEBUG but since we ship at that logging level
>> I would suggest removing it.
>>
>> J-D
>
>
>
Re: "expecting X results" spam
Posted by Ted Yu <yu...@gmail.com>.
+1 on removing it.
On Oct 6, 2011, at 5:26 PM, Jean-Daniel Cryans <jd...@apache.org> wrote:
> Hey devs,
>
> I was testing out 0.92 and HCM got this like this a year ago:
>
> + if (LOG.isDebugEnabled()) {
> + LOG.debug("expecting "+results.length+" results");
> + }
>
> coming from HBASE-2002 (it's triggered for every processBatchCallback). Was
> it intentional? It sure is at DEBUG but since we ship at that logging level
> I would suggest removing it.
>
> J-D