You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/05/22 14:37:31 UTC
[GitHub] incubator-zeppelin pull request: [MINOR] Remove redundant logic of...
GitHub user jongyoul opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/909
[MINOR] Remove redundant logic of JDBC Interpreter
### What is this PR for?
Removing redundant codes and expanding features for passing extra properties into JDBC driver
### What type of PR is it?
[Bug Fix | Improvement]
### Todos
* [x] - Removed logic
### What is the Jira issue?
* MINOR issue
### How should this be tested?
Just passed additional information into your JDBC
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/incubator-zeppelin minor-remove-logic-for-check-user-pass-from-jdbc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #909
----
commit 0a72a57bd237b9088ffcd7852be0107b275cdefe
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-05-22T14:34:19Z
[MINOR] Remove redundant logic of JDBC Interpreter
- Removed logic for checking user and pass from properties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [MINOR] Remove redundant logic of...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/909#issuecomment-220872955
This PR is a very trivial. Merging if there's no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [MINOR] Remove redundant logic of...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/909#issuecomment-220835870
@wfhartford I think it's okay to satisfy your concern. Could you please review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [MINOR] Remove redundant logic of...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/909
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [MINOR] Remove redundant logic of...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/909#issuecomment-220890903
Tested, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [MINOR] Remove redundant logic of...
Posted by wfhartford <gi...@git.apache.org>.
Github user wfhartford commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/909#issuecomment-220843059
Awesome, thanks. That looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [MINOR] Remove redundant logic of...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/909#issuecomment-221177604
LGTM! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---