[GitHub] [arrow-rs] viirya commented on a change in pull request #1457: Fix generate_map_case

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #1457:
URL: https://github.com/apache/arrow-rs/pull/1457#discussion_r829231572



##########
File path: integration-testing/src/lib.rs
##########
@@ -569,6 +569,31 @@ fn array_from_json(
             }
             Ok(Arc::new(b.finish()))
         }
+        DataType::Map(child_field, _) => {
+            let null_buf = create_null_buf(&json_col);
+            let children = json_col.children.clone().unwrap();
+            let child_array = array_from_json(
+                child_field,
+                children.get(0).unwrap().clone(),

Review comment:
       MapType has only one child. Like `DataType::List` logic, I directly get this child. We can add a check and return an error, if you think it is better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org