[jira] Closed: (THRIFT-852) Missing newline causes many compiler warnings

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-852.
--------------------------------

         Assignee: Anthony Molinaro
    Fix Version/s: 0.5
       Resolution: Fixed

I just commtted this to trunk.

> Missing newline causes many compiler warnings
> ---------------------------------------------
>
>                 Key: THRIFT-852
>                 URL: https://issues.apache.org/jira/browse/THRIFT-852
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (General)
>    Affects Versions: 0.4, 0.5
>            Reporter: Anthony Molinaro
>            Assignee: Anthony Molinaro
>             Fix For: 0.5
>
>         Attachments: newline.patch
>
>
> When compiling with -Wall, I see a lot of these
> gmake[3]: Entering directory `/home/molinaro/thrift-0.4.0/compiler/cpp'
> g++ -DHAVE_CONFIG_H -I. -I../..   -I/usr/local/include -Wall -I./src -I/usr/include -g -O3 -funroll-loops -I/usr/local/include -MT thrift-thrifty.o -MD -MP -MF .deps/thrift-thrifty.Tpo -c -o thrift-thrifty.o `test -f 'thrifty.cc' || echo './'`thrifty.cc
> In file included from ./src/parse/t_program.h:41,
>                  from thrifty.yy:35:
> ./src/generate/t_generator_registry.h:103:7: warning: no newline at end of file
> Which is easily fixed with the attached patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.