You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by fpj <gi...@git.apache.org> on 2016/10/28 09:15:44 UTC
[GitHub] zookeeper pull request #95: ZOOKEEPER-2622: ZooTrace.logQuorumPacket does no...
GitHub user fpj opened a pull request:
https://github.com/apache/zookeeper/pull/95
ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing
DO NOT MERGE
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fpj/zookeeper ZK-2622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit 76681a075e045107f149e5ab67756991faf1d8ba
Author: fpj <fp...@apache.org>
Date: 2016-10-28T09:14:51Z
ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #95: ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/95
Go ahead @arshadmohammad! \U0001f603
My only observation is that this dead code is also in branch-3.4 and branch-3.5 so I would advise to cherry-pick it to those branches too, right @fpj ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #95: ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing
Posted by arshadmohammad <gi...@git.apache.org>.
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/95
LGTM, I will commit it.
@eribeiro do you have any comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #95: ZOOKEEPER-2622: ZooTrace.logQuorumPacket does no...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/95
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---