[jira] [Commented] (OFBIZ-12169) Handle remaining checkstyle errors

["Michael Brohl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279861#comment-17279861 ] 

Michael Brohl commented on OFBIZ-12169:
---------------------------------------

There are about 59 errors where checkstyle suggests to make a class final.

Seeing OFBiz as an isolated software package, this sounds reasonable.

Seeing OFBiz as an extendable framework, it might come handy if classes can be extended for custom projects, like *Worker classes.

So the question is if we want to get rid of the checkstyle issues in any case or differentiate a bit more ?

> Handle remaining checkstyle errors
> ----------------------------------
>
>                 Key: OFBIZ-12169
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12169
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> There are still a ggod amount of checkstyle errors which should be addressed.
> We will work on it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)