svn commit: r1396453 - /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestServlet.java

[hs...@apache.org]

Author: hsaputra
Date: Wed Oct 10 03:00:36 2012
New Revision: 1396453

URL: http://svn.apache.org/viewvc?rev=1396453&view=rev
Log:
SHINDIG-1866 | Improve servicability of the MakeRequest servlet handling classes | Path by Erik Bi. Thanks

Modified:
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestServlet.java

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestServlet.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestServlet.java?rev=1396453&r1=1396452&r2=1396453&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestServlet.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestServlet.java Wed Oct 10 03:00:36 2012
@@ -18,10 +18,13 @@
  */
 package org.apache.shindig.gadgets.servlet;
 
+import org.apache.shindig.common.logging.i18n.MessageKeys;
 import org.apache.shindig.common.servlet.InjectedServlet;
 import org.apache.shindig.gadgets.GadgetException;
 
 import java.io.IOException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
@@ -39,6 +42,8 @@ import com.google.inject.Inject;
 public class MakeRequestServlet extends InjectedServlet {
 
   private static final long serialVersionUID = -8298705081500283786L;
+  private static final String classname = MakeRequestServlet.class.getName();
+  private static final Logger LOG = Logger.getLogger(classname, MessageKeys.MESSAGES);
 
   private transient MakeRequestHandler makeRequestHandler;
 
@@ -54,6 +59,9 @@ public class MakeRequestServlet extends 
     try {
       makeRequestHandler.fetch(request, response);
     } catch (GadgetException e) {
+      if (LOG.isLoggable(Level.FINEST)) {
+        LOG.logp(Level.FINEST, classname, "doGet", MessageKeys.HTTP_ERROR_FETCHING, e);
+      }
       int responseCode = HttpServletResponse.SC_INTERNAL_SERVER_ERROR;
       if (e.getCode() != GadgetException.Code.INTERNAL_SERVER_ERROR) {
         responseCode = HttpServletResponse.SC_BAD_REQUEST;