[jira] [Commented] (HIVE-17540) remove feature: describe pretty

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190129#comment-16190129 ] 

Hive QA commented on HIVE-17540:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12890171/HIVE-17540.01.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 11192 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_predicate_pushdown] (batchId=231)
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_single_sourced_multi_insert] (batchId=231)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan] (batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=156)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1] (batchId=170)
org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=239)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=202)
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testWriteSmallint (batchId=183)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7095/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7095/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7095/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12890171 - PreCommit-HIVE-Build

> remove feature: describe pretty
> -------------------------------
>
>                 Key: HIVE-17540
>                 URL: https://issues.apache.org/jira/browse/HIVE-17540
>             Project: Hive
>          Issue Type: Wish
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-17540.01.patch
>
>
> I've bumped into "describe pretty" feature...which was probably a usefull thing when it was introduced....but I haven't seen it documented anywhere ... google [results|https://www.google.hu/search?num=50&q=%22describe+pretty%22+hive&oq=%22describe+pretty%22+hive&gs_l=psy-ab.3..35i39k1.4651.6121.0.6290.3.3.0.0.0.0.96.271.3.3.0....0...1.1.64.psy-ab..0.3.270....0.NzSfMzfEfs8] are only about the implementation of the feature.
> there are qtest about it:
> https://github.com/apache/hive/blob/88ca553c451d8d23778a912ec26b262eda402c68/ql/src/test/queries/clientpositive/describe_pretty.q#L35
> https://github.com/apache/hive/blob/88ca553c451d8d23778a912ec26b262eda402c68/ql/src/test/results/clientpositive/describe_pretty.q.out#L43
> this feature makes it possible to render column comments more nicely...
> I think beeline is already able to address formatting issues like this at a much wider scale; so it might be ok to remove the 'describe pretty' support...or at least I think it would be better to put efforts into displaying things on beeline more nicely



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)