[jira] [Commented] (SPARK-19499) Add more notes in the comments of Sink.addBatch()

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-19499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856508#comment-15856508 ] 

Apache Spark commented on SPARK-19499:
--------------------------------------

User 'CodingCat' has created a pull request for this issue:
https://github.com/apache/spark/pull/16840

> Add more notes in the comments of Sink.addBatch() 
> --------------------------------------------------
>
>                 Key: SPARK-19499
>                 URL: https://issues.apache.org/jira/browse/SPARK-19499
>             Project: Spark
>          Issue Type: Improvement
>          Components: Structured Streaming
>    Affects Versions: 2.0.0, 2.0.1, 2.0.2, 2.1.0
>            Reporter: Nan Zhu
>            Priority: Minor
>
> addBatch method in Sink trait is supposed to be a synchronous method to coordinate with the fault-tolerance design in StreamingExecution (being different with the compute() method in DStream)
> We need to add more notes in the method of this method to remind the developers



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org