[GitHub] incubator-carbondata pull request #83: [CARBONDATA-169]ColDict and All Dicti...

[manishgupta88 <gi...@git.apache.org>]

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/83#discussion_r75860533
  
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
    @@ -1001,6 +1001,12 @@ class CarbonSqlParser()
           "SERIALIZATION_NULL_FORMAT",
           "ALL_DICTIONARY_PATH"
         )
    +    if (options.exists(_._1.equalsIgnoreCase("COLUMNDICT")) &&
    +      options.exists(_._1.equalsIgnoreCase("ALL_DICTIONARY_PATH"))) {
    +      val errorMessage = "Error: COLUMNDICT and ALL_DICTIONARY_PATH can not be used together" +
    +        " in options"
    +      throw new MalformedCarbonCommandException(errorMessage)
    +    }
    --- End diff --
    
    @Jay357089 .....Move this newly added code below if loop for not isSupported check. I think ideally first we should validate the options whether they are among the ones allowed for load command and then perform other checks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---