[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4041: add uuid() function

[GitBox <gi...@apache.org>]

alamb commented on code in PR #4041:
URL: https://github.com/apache/arrow-datafusion/pull/4041#discussion_r1009665918


##########
datafusion/expr/src/function.rs:
##########
@@ -157,6 +157,7 @@ pub fn return_type(
             utf8_to_int_type(&input_expr_types[0], "octet_length")
         }
         BuiltinScalarFunction::Random => Ok(DataType::Float64),
+        BuiltinScalarFunction::Uuid => Ok(DataType::Utf8),

Review Comment:
   I wonder if we want to try and return bytes (`DataType::Binary`) instead of strings (and allow casting from bytes to string for anyone who wants strings) 🤔 



##########
datafusion/physical-expr/Cargo.toml:
##########
@@ -57,3 +57,4 @@ rand = "0.8"
 regex = { version = "^1.4.3", optional = true }
 sha2 = { version = "^0.10.1", optional = true }
 unicode-segmentation = { version = "^1.7.1", optional = true }
+uuid = { version = "^1.2", features = ["v4"] }

Review Comment:
   Moar dependencies 😢 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org