You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/22 01:04:14 UTC
[GitHub] [apisix] RocFang opened a new pull request #2493: optimize: read trailing bytes only one time in stand-alone mode.
RocFang opened a new pull request #2493:
URL: https://github.com/apache/apisix/pull/2493
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
IMHO, there is no need to loop 10 times for read trailing bytes in stand-alone mode,
or maybe there is some special reason i didn't get.
If so, @membphis would you please explain it a little? thanks.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2493: optimize: read trailing bytes only one time in stand-alone mode.
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2493:
URL: https://github.com/apache/apisix/pull/2493#issuecomment-714195749
@RocFang your way is correct and better. I have approved, many thx for your contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #2493: optimize: read trailing bytes only one time in stand-alone mode.
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2493:
URL: https://github.com/apache/apisix/pull/2493
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org