[GitHub] [skywalking] wu-sheng opened a new pull request #4633: Set up restrict length rules for service, instance and endpoint

[GitBox <gi...@apache.org>]

wu-sheng opened a new pull request #4633: Set up restrict length rules for service, instance and endpoint
URL: https://github.com/apache/skywalking/pull/4633
 
 
   In 8.x, as we are using encoding rather than register, the length of service/instance/endpoint are more sensitive to the backend.(We used to only be sensitive in MySQL/H2 storage).
   
   I provide the following config in the core module, and provide default settings too.
   ```yaml
   core:
     selector: ${SW_CORE:default}
     default:
       # The max length of service + instance names should be less than 200
       serviceNameMaxLength: ${SW_SERVICE_NAME_MAX_LENGTH:70}
       instanceNameMaxLength: ${SW_INSTANCE_NAME_MAX_LENGTH:70}
       # The max length of service + endpoint names should be less than 240
       endpointNameMaxLength: ${SW_ENDPOINT_NAME_MAX_LENGTH:150}
   ```
   
   Currently, I would not shut down the OAP in the bootstrap process, if users really set the length out of the suggestion values.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng merged pull request #4633: Set up restrict length rules for service, instance and endpoint

[GitBox <gi...@apache.org>]

wu-sheng merged pull request #4633: Set up restrict length rules for service, instance and endpoint
URL: https://github.com/apache/skywalking/pull/4633
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services