[jira] Commented: (MAPREDUCE-1334) contrib/index - test - TestIndexUpdater fails due to an additional presence of file _SUCCESS in hdfs

["Hemanth Yamijala (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967203#action_12967203 ] 

Hemanth Yamijala commented on MAPREDUCE-1334:
---------------------------------------------

Twice now, Hudson didn't seem to have picked this patch up.

Here's the output of test-patch:

    [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.8) warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.

Since this change only affects the Index contrib project, I ran ant test with the patch on, and it passed

test:
     [echo] contrib: index
   [delete] Deleting directory /home/yhemanth/commit-workspace/mapreduce/trunk/build/contrib/index/test/logs
    [mkdir] Created dir: /home/yhemanth/commit-workspace/mapreduce/trunk/build/contrib/index/test/logs
   [delete] Deleting directory /home/yhemanth/commit-workspace/mapreduce/trunk/build/contrib/index/test/sample
    [mkdir] Created dir: /home/yhemanth/commit-workspace/mapreduce/trunk/build/contrib/index/test/sample
     [copy] Copying 2 files to /home/yhemanth/commit-workspace/mapreduce/trunk/build/contrib/index/test/sample
    [junit] WARNING: multiple versions of ant detected in path for junit 
    [junit]          jar:file:/home/yhemanth/software/apache-ant-1.7.1/lib/ant.jar!/org/apache/tools/ant/Project.class
    [junit]      and jar:file:/home/yhemanth/commit-workspace/mapreduce/trunk/build/ivy/lib/Hadoop/common/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
    [junit] Running org.apache.hadoop.contrib.index.lucene.TestMixedDirectory
    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.28 sec
    [junit] Running org.apache.hadoop.contrib.index.mapred.TestDistributionPolicy
    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 58.314 sec
    [junit] Running org.apache.hadoop.contrib.index.mapred.TestIndexUpdater
    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 68.195 sec


Based on this, I will commit the patch.

> contrib/index - test - TestIndexUpdater fails due to an additional presence of file _SUCCESS in hdfs 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1334
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1334
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/index
>            Reporter: Kay Kay
>            Assignee: Kay Kay
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-1334.patch, MAPREDUCE-1334.patch
>
>
> $ cd src/contrib/index
> $ ant clean test 
> This fails the test TestIndexUpdater due to a mismatch in the - doneFileNames - data structure, when it is being run with different parameters. 
> (ArrayIndexOutOfBoundsException raised when inserting elements in doneFileNames, array ). 
> Debugging further - there seems to be an additional file called as - hdfs://localhost:36021/myoutput/_SUCCESS , taken into consideration in addition to those that begins with done* .  The presence of the extra file causes the error. 
> Attaching a patch that would circumvent this by increasing the array length of shards by 1 . 
> But longer term the test fixtures need to be probably revisited to see if the presence of _SUCCESS as a file is a good thing to begin with before we even get to this test case. 
> Any comments / suggestions on the same welcome. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.