You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2016/01/06 15:11:28 UTC

Re: Review Request 41550: Quota: Added tests for quota removal authorization.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/
-----------------------------------------------------------

(Updated Jan. 6, 2016, 2:11 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Summary (updated)
-----------------

Quota: Added tests for quota removal authorization.


Bugs: MESOS-4083
    https://issues.apache.org/jira/browse/MESOS-4083


Repository: mesos


Description (updated)
-------

see summary.


Diffs
-----

  src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 

Diff: https://reviews.apache.org/r/41550/diff/


Testing
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 41550: Quota: Added tests for quota removal authorization.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113085
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41546, 41547, 41548, 41549, 41550]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 2:34 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 2:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
>     https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 41550: Quota: Added tests for quota removal authorization.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/
-----------------------------------------------------------

(Updated Jan. 6, 2016, 3:34 p.m.)


Review request for mesos, Alexander Rukletsov and Till Toenshoff.


Changes
-------

Addressed issues.


Bugs: MESOS-4083
    https://issues.apache.org/jira/browse/MESOS-4083


Repository: mesos


Description
-------

see summary.


Diffs (updated)
-----

  src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
  src/tests/master_quota_tests.cpp 81f0386d072d0176cb28eb229b274e424004f54c 

Diff: https://reviews.apache.org/r/41550/diff/


Testing
-------

make check


Thanks,

Jan Schlicht